Document debug logging. #5671
Merged
Document debug logging. #5671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Dec 30, 2019
| } else { | ||
| log(task, queue, "failed in ${formatDuration(elapsedNs)}") | ||
| log(task, queue, "failed a run in ${formatDuration(elapsedNs)}") |
There was a problem hiding this comment.
carefully chosen words to get the right width!
This was referenced Dec 30, 2019
yschimke
reviewed
Dec 31, 2019
| OkHttp has internal APIs to enable debug logging. It uses the `java.util.logging` API which can be | ||
| tricky to configure. As a shortcut, you can paste [OkHttpDebugLogging.kt]. Then enable debug logging | ||
| for whichever features you need: | ||
|
|
There was a problem hiding this comment.
Probably worth a sentence on Android, example logcat filter etc?
There was a problem hiding this comment.
Added. Turns out hooking up logcat to java.util.Logging nicely is a bit of a pain if you want to use FINE!
There was a problem hiding this comment.
(Good idea though!)
yschimke
approved these changes
Dec 31, 2019
|
Nice user friendly change! |
swankjesse
force-pushed
the
jwilson.1230.debug_logging
branch
2 times, most recently
from
37d3663 to
a2f0fe7
Compare
Also refine the formatting of TaskRunner logging.
Before:
[2019-12-30 16:43:19] Q1 starting: OkHttp ConnectionPool
[2019-12-30 16:43:19] Q1 scheduled after 300 s: OkHttp ConnectionPool
[2019-12-30 16:43:19] Q1 finished in 94 µs: OkHttp ConnectionPool
[2019-12-30 16:43:19] Q359 scheduled after 0 µs: OkHttp www.youtube.com applyAndAckSettings
[2019-12-30 16:43:19] Q359 starting: OkHttp www.youtube.com applyAndAckSettings
[2019-12-30 16:43:19] Q361 schedule canceled (queue is shutdown): OkHttp www.youtube.com onSettings
[2019-12-30 16:43:19] Q359 finished in 382 µs: OkHttp www.youtube.com applyAndAckSettings
[2019-12-30 16:43:20] Q1 scheduled after 0 µs: OkHttp ConnectionPool
[2019-12-30 16:43:20] Q365 scheduled after 0 µs: OkHttp android-developers.googleblog.com applyAndAckSettings
[2019-12-30 16:43:20] Q1 starting: OkHttp ConnectionPool
[2019-12-30 16:43:20] Q365 starting: OkHttp android-developers.googleblog.com applyAndAckSettings
[2019-12-30 16:43:20] Q1 scheduled after 300 s: OkHttp ConnectionPool
[2019-12-30 16:43:20] Q1 finished in 151 µs: OkHttp ConnectionPool
After:
[2019-12-30 16:43:19] Q10001 starting : OkHttp ConnectionPool
[2019-12-30 16:43:19] Q10001 run again after 300 s : OkHttp ConnectionPool
[2019-12-30 16:43:19] Q10001 finished run in 94 µs: OkHttp ConnectionPool
[2019-12-30 16:43:19] Q10359 scheduled after 0 µs: OkHttp www.youtube.com applyAndAckSettings
[2019-12-30 16:43:19] Q10359 starting : OkHttp www.youtube.com applyAndAckSettings
[2019-12-30 16:43:19] Q10361 schedule canceled (queue is shutdown): OkHttp www.youtube.com onSettings
[2019-12-30 16:43:19] Q10359 finished run in 382 µs: OkHttp www.youtube.com applyAndAckSettings
[2019-12-30 16:43:20] Q10001 scheduled after 0 µs: OkHttp ConnectionPool
[2019-12-30 16:43:20] Q10365 scheduled after 0 µs: OkHttp android-developers.googleblog.com applyAndAckSettings
[2019-12-30 16:43:20] Q10001 starting : OkHttp ConnectionPool
[2019-12-30 16:43:20] Q10365 starting : OkHttp android-developers.googleblog.com applyAndAckSettings
[2019-12-30 16:43:20] Q10001 run again after 300 s : OkHttp ConnectionPool
[2019-12-30 16:43:20] Q10001 finished run in 151 µs: OkHttp ConnectionPool
swankjesse
force-pushed
the
jwilson.1230.debug_logging
branch
from
a2f0fe7 to
a815093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refine the formatting of TaskRunner logging.
Before:
After: